Merged
Conversation
|
E2E Tests 🚀 |
Contributor
austin3dickey
left a comment
austin3dickey
left a comment
There was a problem hiding this comment.
Looks great! Small things:
austin3dickey
previously approved these changes
Aug 20, 2025
Contributor
austin3dickey
left a comment
austin3dickey
left a comment
There was a problem hiding this comment.
Thank you! Exciting!
Contributor
Author
|
hmmm...with |
Contributor
Author
|
Looks like our build process for smoke testing is different than upstream, which mostly is fine but they're specifically putting PET into testing paths in the test itself, where we place PET at build time. Since we run our own e2e tests that have the same functionality, I feel pretty okay skipping these smoke tests and logging turning smoke tests on for later work. Does that sound reasonable? |
Contributor
|
In favor of this, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes from "js" locator to the PET. 🎉
This PR also removes CI runs for upstream smoke tests. This was brought on due to the fact that smoke tests do not run from the expected
positron/extensions/positron-pythondirectory, so thepetbinary would need to be redownloaded and inserted into the temporary testing path. We have disabled all behavior that is being tested in the smoke tests besides: checking if the LSP is on, running a Python file in the terminal, and checking if Smart Send is on. These are all features that are covered in Positron's own e2e tests. Since the smoke tests are not adding additional coverage or information to our testing suite, we decided to remove them completely.Release Notes
New Features
Bug Fixes
QA Notes
passes CI and if you poke around in different workspaces, Python should be discovered. I don't think we need to add "native" to the e2e settings anymore.